Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add separate schematics package? #31

Closed
Airblader opened this issue Dec 27, 2018 · 1 comment
Closed

[Feature] Add separate schematics package? #31

Airblader opened this issue Dec 27, 2018 · 1 comment
Labels
Status: Discussion We're not yet sure whether or how to implement this feature Type: Feature If you want to add something that doesn't exist yet

Comments

@Airblader
Copy link
Collaborator

If we added a separate @ngqp/schematics package to handle ng add, we could determine the Angular version used and install the appropriate ngqp version. This assumes we align the versions with Angular.
@Airblader Airblader added Type: Feature If you want to add something that doesn't exist yet Status: Discussion We're not yet sure whether or how to implement this feature labels Dec 27, 2018
@Airblader
Copy link
Collaborator Author

Actually we can avoid a separate package, I think. We just detect the Angular version and add the appropriate entry to the package json. It seems that Angular Material does something like this too.

Airblader added a commit that referenced this issue Dec 27, 2018
@Airblader
fix(schematics): Try to infer the correct version to install
5e0ab8b 
relates #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Discussion We're not yet sure whether or how to implement this feature Type: Feature If you want to add something that doesn't exist yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Airblader