Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 6 #8

Closed
lps88 opened this issue Jul 26, 2018 · 10 comments
Closed

Support for Angular 6 #8

lps88 opened this issue Jul 26, 2018 · 10 comments

Comments

@lps88
Copy link

lps88 commented Jul 26, 2018

I am struggling to get this library to work in my Angular 6 project. I have spun up a brand new project with the CLI and followed the installation steps and it is giving this error (I can upload the repo if it will help):

Error: StaticInjectorError(AppModule)[AppComponent -> t]: 
  StaticInjectorError(Platform: core)[AppComponent -> t]: 
    NullInjectorError: No provider for t!
    at NullInjector.push../node_modules/@angular/core/fesm5/core.js.NullInjector.get (core.js:1060)
    at resolveToken (core.js:1298)
    at tryResolveToken (core.js:1242)
    at StaticInjector.push../node_modules/@angular/core/fesm5/core.js.StaticInjector.get (core.js:1139)
    at resolveToken (core.js:1298)
    at tryResolveToken (core.js:1242)
    at StaticInjector.push../node_modules/@angular/core/fesm5/core.js.StaticInjector.get (core.js:1139)
    at resolveNgModuleDep (core.js:8377)
    at NgModuleRef_.push../node_modules/@angular/core/fesm5/core.js.NgModuleRef_.get (core.js:9065)
    at resolveDep (core.js:9430)

Is Angular 6 supported at all, or are there plans to support it in the near future?

Thanks

@tnicola
Copy link
Owner

tnicola commented Jul 26, 2018

Hi @lps88 ,

Unfortunately Angular 6 is not yet supported but it will be soon. It's the next thing on the roadmap! I'll be on holiday next week, I'll release the next version with Angular 6 support for mid August more or less.

Thank you

@lps88
Copy link
Author

lps88 commented Jul 27, 2018

@tnicola thanks for the update :)

@artemkosenko
Copy link

Hi, @lps88 , @tnicola

Here is a simple workaround for Angular 6.
imports: [ JoyrideModule.forRoot() ]

@geokaf2
Copy link

geokaf2 commented Aug 13, 2018

Really anticipating for the version compatible with Angular 6 and new rjx libraries. In my opinion the best tour library out there!! Great Work!!!

@artemkosenko
Copy link

artemkosenko commented Aug 13, 2018

@geokaf2
See this fork https://github.com/artemkosenko/ngx-joyride
rxjs 6 is used. No need for rxjs-compat.

@geokaf2
Copy link

geokaf2 commented Aug 13, 2018

Great @artemkosenko !! I will check it out!!

@geokaf2
Copy link

geokaf2 commented Aug 13, 2018

Hi @artemkosenko again!
Is it published or should i clone and build the library?

@artemkosenko
Copy link

@geokaf2
It ain't published anywhere.

@geokaf2
Copy link

geokaf2 commented Aug 13, 2018

Ok thanks!!!

@tnicola
Copy link
Owner

tnicola commented Aug 15, 2018

A new version 2.1.0 with Angular 6 support has been published. No breaking changes have been introduced!
Thanks to @artemkosenko for his contribute.

@tnicola tnicola closed this as completed Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants