Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeSet URL setting to link revisions on /changes/ page #35

Open
techtonik opened this issue Jun 22, 2011 · 4 comments
Open

ChangeSet URL setting to link revisions on /changes/ page #35

techtonik opened this issue Jun 22, 2011 · 4 comments
Labels

Comments

@techtonik
Copy link

On http://speed.pypy.org/changes/ revisions are not linked to specific revisions. I guess that's because codespeed doesn't have a setting or can not link Mercurial revisions.

@tobami
Copy link
Owner

tobami commented Jun 22, 2011

You mean a direct link to the Bitbucket changeset page?

To do that, Codespeed would need to now the Bitbucket URL convention, which means that a Bitbucket plugin (instead of the current plain mercurial) would need to be implemented.

Bitbucket's URL for chancheset links is of the form
https://bitbucket.org/<project_url>/changeset/<commit_id>

@techtonik
Copy link
Author

Does it really need a plugin? I believe that simple setting for browser URL, where revision is just appended to it can cover 95% of VCS browsers out there. With support for expansion variables like $commit_id in this URL, a full coverage can be reached.

@tobami
Copy link
Owner

tobami commented Jun 25, 2011

You may be right. A new field "browsing URL" would be enough for most cases.
(The current GitHub plugin exists not because it needs that url, but because it uses Github's API isntead of locally git cloning the repo)

@squiddy
Copy link
Contributor

squiddy commented Dec 3, 2011

Here is my attempt at implementing this feature. It adds a new field to a project, that will be used to construct the URL for a commit. It will be used by string.format and is passed a single log entry, so you can access fields like {commitid}.

https://github.com/squiddy/codespeed/tree/35_browse_changeset

The first commit is related to #91, I quickly added (it's probably incorrect) that to avoid mixing both changes together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants