New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalinks for Environments should use id instead of name #38

Closed

tobami opened this issue Jun 22, 2011 · 1 comment

Labels

BUG

Owner

tobami commented Jun 22, 2011

As the new Codespeed site shows, the environment name is used for the permalink:
http://speed.rubyspec.org/changes/?tre=10&rev=268a0200d16b42f5201ba6c9faa2cd84447a6487&exe=2&env=EC2+(OpenJDK)

Clicking on a Report row (front page) will even take you to a permalink with no url encoding but plain text:
env=EC2 (OpenJDK6)

It would be better to use an id. That would also allow to modify the name of an environment and not break permalinks.

The revision can also be changed to id, to reduce the total URL length

tobami closed this as completed

Owner Author

tobami commented Jul 3, 2011

Environment ids are now implemented, moving revisions to #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment