-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1822 family] allowed to sell fewer shares than needed, leading to taking a loan #10059
Comments
The duplicate issues refer to 4 games (plus one archived game):
Locally I tried running from the commits that have been turned into pins, all the way back to 189006e from early October, and repeatedly got the same error in all of them. Maybe during December 14-29 it was possible to make the illegal move, but both before and after the time period it was prevented? The dates of the closest pin commits are December 6 and December 30, so possibly a release in between them is responsible. Best guess at related PRs are #9989 and #10031, will dig into those some more. |
Found 87 finished broken games in the 1822 family, didn't check all of them, but archived them, assuming they had a similar issue. |
Found one more broken 1822 game, 141115, also pinned that one. |
Having run a validation on the prod server, I believe all affected games are fixed. If the issue comes up again, the first thing to try is to pin the affected game to |
In this 1822CA gist, Kurt had the option of selling 1 or 2 shares of GTP. After selling only 1 (and selling the other sellable share he held), he was forced to take a loan to pay for the train. He should have instead been forced to sell 2 GTP shares instead of just 1.
To fix this we'd need to add some check looking for the total sellable shares and prevent a loan from happening if that total is enough to buy a train without the loan, or make sure smaller bundles aren't sellable if selling them would lead to a loan.
I suspect this also affects 1822MX, 1822PNW, and 1822Africa--other 1822 games with
MUST_SELL_IN_BLOCKS = true
.Standard 1822 doesn't have this problem, he would have just been able to sell the 2nd share after selling the first.update: it's not just a sell in blocks issue
SEO
"need to sell shares before a loan can be granted"
Shares must be sold before a loan is taken
Shares must be sold before loan granted
The text was updated successfully, but these errors were encountered: