Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1822] fix for full_or_turn SELL_AFTER case. #10031

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

philcampeau
Copy link
Collaborator

Fixes #10026

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Explanation of Change
    The code previously didn't take into account that it would prevent you from selling stock in another corp which had operated only once if you were also the president of that corp. This should fix that by also checking if the bundle.corporation is the @round.current_operator.

I ran a couple of tests, but given its failure the first time, I'd appreciate it if someone else can't take a look and make sure I got it right this time.

  • Screenshots

  • Any Assumptions / Hacks

@philcampeau philcampeau added pins PR that will require some games to be pinned 1822 1822MX 1822PNW 1822Africa 1822CA labels Dec 18, 2023
@tobymao tobymao merged commit 16b12e3 into tobymao:master Dec 28, 2023
1 check passed
@philcampeau philcampeau deleted the 1822_emr_correction branch February 7, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1822Africa 1822CA 1822MX 1822PNW 1822 pins PR that will require some games to be pinned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1822 - Cannot sell shares in a company that has already operated
2 participants