[1822] fix for full_or_turn SELL_AFTER case. #10031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10026
Before clicking "Create"
master
pins
label if this change will break existing gamesdocker compose exec rack rubocop -a
docker compose exec rack rake
Implementation Notes
The code previously didn't take into account that it would prevent you from selling stock in another corp which had operated only once if you were also the president of that corp. This should fix that by also checking if the bundle.corporation is the @round.current_operator.
I ran a couple of tests, but given its failure the first time, I'd appreciate it if someone else can't take a look and make sure I got it right this time.
Screenshots
Any Assumptions / Hacks