Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18PNW] autopass if no tokens left in corp #10022

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

benjaminxscott
Copy link
Collaborator

@benjaminxscott benjaminxscott commented Dec 16, 2023

Fixes #9956

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Explanation of Change

In the code that decides whether a corp has any actions besides pass, the check for a 'station swap' private was erroneously returning true, since the station swap private was defined at a higher level. We undefine it to fix this logic for the case of PNW

  • Screenshots

  • Any Assumptions / Hacks

@benjaminxscott benjaminxscott added the pins PR that will require some games to be pinned label Dec 16, 2023
@tobymao tobymao merged commit 5eb5a09 into tobymao:master Dec 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pins PR that will require some games to be pinned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1822PNW token problem
2 participants