Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chips/earlgrey/chip_config: increase CW310 FPGA clock frequencies #3639

Closed

Conversation

lschuermann
Copy link
Member

Pull Request Overview

This is in accordance with an upstream change 1. While the register set and other chip attributes are frozen for EarlGrey, the clock frequencies are not. This change will also be backported to the lowRISC/opentitan earlgrey_es branch 2.

Testing Strategy

This pull request was tested by running Tock on latest OpenTitan master on a CW310 FPGA.

TODO or Help Wanted

N/A

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

This is in accordance with an upstream change [1]. While the register
set and other chip attributes are frozen for EarlGrey, the clock
frequencies are not. This change will also be backported to the
lowRISC/opentitan `earlgrey_es` branch [2].

[1]: lowRISC/opentitan#19368
[2]: lowRISC/opentitan#19479
@github-actions github-actions bot added the WG-OpenTitan In the purview of the OpenTitan working group. label Aug 22, 2023
@lschuermann
Copy link
Member Author

Ping @cfrantz

@bradjc
Copy link
Contributor

bradjc commented Aug 22, 2023

How does this relate to

OPENTITAN_SUPPORTED_SHA := 21ce4e9761abdf5c919b46e5ae64a5a8e24992f7

@lschuermann
Copy link
Member Author

How does this relate to

OPENTITAN_SUPPORTED_SHA := 21ce4e9761abdf5c919b46e5ae64a5a8e24992f7

Yeah ... good point. We'll want to put this PR on hold until we have a new stable bitstream to increment to. My bad.

@lschuermann lschuermann added the blocked-upstream Waiting on something from an upstream project label Aug 22, 2023
Copy link
Contributor

@cfrantz cfrantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after lowRISC/opentitan#19479 gets submitted on the earlgrey_es branch.

We'll need to update the OpenTitan SHA afterwards.

Note that the changes to clock frequencies don't change any of the Earlgrey hardware implementation - they only change the base clocks for the FPGA synthesis.

@bradjc
Copy link
Contributor

bradjc commented Sep 13, 2023

@cfrantz Is there an updated bitstream?

@cfrantz
Copy link
Contributor

cfrantz commented Sep 18, 2023

@cfrantz Is there an updated bitstream?

I've tested this change with opentitan/master@HEAD and with opentitan/earlgrey_es@7df72d61f536e9babb343219232783e5e49f7ceb. Both worked.

The earlgrey_es bitstream is available from the opentitan-bitstreams GCP bucket here: https://storage.googleapis.com/opentitan-bitstreams/earlgrey_es/bitstream-7df72d61f536e9babb343219232783e5e49f7ceb.tar.gz

I think this can go in as long as we update the OPENTITAN_SUPPORTED_SHA.

@bradjc
Copy link
Contributor

bradjc commented Sep 18, 2023

Awesome!

@bradjc bradjc added waiting-on-author needs-rebase and removed blocked-upstream Waiting on something from an upstream project labels Sep 18, 2023
jrvanwhy added a commit to jrvanwhy/tock that referenced this pull request Oct 6, 2023
…requencies.

I failed to test this myself (I was unable to find the rsa.tbf that board/opentitan/README.md thought would exist) so I used the already-tested commit here: tock#3639 (comment)
@bradjc
Copy link
Contributor

bradjc commented Oct 6, 2023

Replaced by #3703

@bradjc bradjc closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase waiting-on-author WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants