Make t/pty.t test pass on OpenBSD. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Line 119 does the same thing, but it's part of a block skipped on OpenBSD.
Instead of adding a second instance, I recommend moving lines 117-120 above the
SKIP block and expanding the comment to mention the OpenBSD need.
…On Wed, Sep 08, 2021 at 02:31:06PM -0700, Alexander Bluhm wrote:
OpenBSD libc devname(3) opens /var/run/dev.db and keeps it open.
As this would confuse open file descriptor checks, open it in advance.
You can view, comment on, or merge this pull request online at:
#150
-- Commit Summary --
* Make t/pty.t test pass on OpenBSD.
-- File Changes --
M t/pty.t (4)
-- Patch Links --
https://github.com/toddr/IPC-Run/pull/150.patch
https://github.com/toddr/IPC-Run/pull/150.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#150
|
OpenBSD libc devname(3) opens /var/run/dev.db and keeps it open. As this would confuse open file descriptor checks, open it in advance. Move this logic out of the block that is skipped on some platforms
|
Looks good. Maintainers: I recommend merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD libc devname(3) opens /var/run/dev.db and keeps it open.
As this would confuse open file descriptor checks, open it in advance.