Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag duplicate in a same post & # in code block is not tag #97

Closed
qaqland opened this issue Apr 29, 2024 · 10 comments
Closed

tag duplicate in a same post & # in code block is not tag #97

qaqland opened this issue Apr 29, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@qaqland
Copy link

qaqland commented Apr 29, 2024

my code block has some c macro

image

https://qaq.land/tags/pragma

Ktistec Version 2.0.0-10

@toddsundsted toddsundsted added the bug Something isn't working label Apr 29, 2024
@toddsundsted
Copy link
Owner

good catch! thanks!

@toddsundsted
Copy link
Owner

fixed in a6ea138. can you confirm?

@qaqland
Copy link
Author

qaqland commented Apr 30, 2024

new post fixed, what about old post🤔

@toddsundsted
Copy link
Owner

you should be able to edit the old post and publish again (as an update). editing always starts with the original source, and when that source is resaved, it will be reprocessed, but this time it won't create hashtags (and the old hashtags will be destroyed).

@qaqland
Copy link
Author

qaqland commented Apr 30, 2024

could you access my instance https://qaq.land ?

it still has https://qaq.land/tags/define and https://qaq.land/tags/pragma

2024-04-30 17:24:26 UTC 200 GET /tags/define 3.72ms
2024-04-30 17:24:29 UTC 200 GET /tags/pragma 5.56ms
2024-04-30 17:26:02 UTC 409 POST /actors/qaq/inbox 510.07ms
2024-04-30 17:27:53 UTC 404 GET /tags/pragma2 3.72ms

@toddsundsted
Copy link
Owner

interesting. that should have deleted the tags in addition to just the tag markup. i'll take a look at it

@toddsundsted
Copy link
Owner

yep, found a bug. when all tags are removed from the post none of the tags get removed.

@toddsundsted
Copy link
Owner

ok, this bug is fixed in a824ce0. if you edit those posts and then update, it should correctly remove the hashtag database entries, as well.

@toddsundsted
Copy link
Owner

@qaqland these two fixes should address the issue you mentioned. can you confirm?

@qaqland
Copy link
Author

qaqland commented May 6, 2024

yes, works well. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants