gitvote: Do not exclude team maintainers from voting #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justaugustus
requested review from
annania,
ashleywolf and
gkunz
and removed request for
a team
Some Steering members are also GitHub organization owners, which will automatically designate us as maintainers of any team we hold membership in (like `gitvote-steering`). This config change allows the subset of Steering members who are also GitHub org owners to have binding votes. Opting to explicitly set this config option to `false`, instead of assuming this will always be the default, so we don't get surprised in the future. Signed-off-by: Stephen Augustus <foo@auggie.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Steering members are also GitHub organization owners, which will automatically designate us as maintainers of any team we hold membership in (like
gitvote-steering).This config change allows the subset of Steering members who are also GitHub org owners to have binding votes.
Opting to explicitly set this config option to
false, instead of assuming this will always be the default, so we don't get surprised in the future.ref: #326 (comment)