Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy edits to get the page ready for publishing #433

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Copy edits to get the page ready for publishing #433

merged 2 commits into from
Feb 27, 2024

Conversation

alice-sowerby
Copy link
Contributor

@alice-sowerby alice-sowerby commented Feb 19, 2024

As per our last meeting, I have edited the page a bit to make it flow a bit more.

Signed-off-by: Alice Sowerby acsowerby@hotmail.com

@anajsana
Copy link
Member

Thank you @alice-sowerby ! All LGTM. I'll let @cornelius to chime in during the week 👍

Copy link
Member

@cornelius cornelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. This is great and makes the text much more readable. I left a few comments at some places where my feeling is that we should keep a nuance, which appeared in the original text.

content/en/guides/employee-engagement.md Outdated Show resolved Hide resolved
content/en/guides/employee-engagement.md Outdated Show resolved Hide resolved
content/en/guides/employee-engagement.md Outdated Show resolved Hide resolved
Good suggestions!

Signed-off-by: Alice Sowerby <acsowerby@hotmail.com>
@alice-sowerby
Copy link
Contributor Author

I made the changes suggested but I'm not sure why the DCO check doesn't pass as it looks to me like it's signed off correctly. @anajsana any ideas how to resolve? Thanks!

Copy link
Member

@cornelius cornelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks a lot. Looks good to me now.

@anajsana
Copy link
Member

Great work everyone and special thanks to @alice-sowerby ! Let's merge 😃

@anajsana anajsana merged commit ba50653 into main Feb 27, 2024
5 checks passed
@alice-sowerby alice-sowerby deleted the copy-edit branch February 28, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants