-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy edits to get the page ready for publishing #433
Conversation
Thank you @alice-sowerby ! All LGTM. I'll let @cornelius to chime in during the week 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. This is great and makes the text much more readable. I left a few comments at some places where my feeling is that we should keep a nuance, which appeared in the original text.
Good suggestions! Signed-off-by: Alice Sowerby <acsowerby@hotmail.com>
I made the changes suggested but I'm not sure why the DCO check doesn't pass as it looks to me like it's signed off correctly. @anajsana any ideas how to resolve? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks a lot. Looks good to me now.
Great work everyone and special thanks to @alice-sowerby ! Let's merge 😃 |
As per our last meeting, I have edited the page a bit to make it flow a bit more.
Signed-off-by: Alice Sowerby acsowerby@hotmail.com