feat: supports sort all page #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
eb8e43b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a4db87e5.affine.pages.dev |
| Branch Preview URL: | https://feat-sort-all-page.affine.pages.dev |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2356 +/- ##
==========================================
- Coverage 72.37% 72.34% -0.03%
==========================================
Files 329 330 +1
Lines 7239 7286 +47
Branches 1135 1169 +34
==========================================
+ Hits 5239 5271 +32
- Misses 1793 1808 +15
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master …sort-all-page +/- ##
===================================================================
< Bundle 3.11 MB 3.23 MB +123 kB(+3.94%)
< Initial JS 1.86 MB 2.05 MB +186 kB(+9.99%)
< Initial CSS 16.8 kB 30.5 kB +13.7 kB(+81.83%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 41 47 +6
< Chunks 39 41 +2
< Packages 132 139 +7
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master …sort-all-page +/- ##
===================================================================
< Bundle 3 MB 3.11 MB +113 kB(+3.78%)
< Initial JS 1.75 MB 1.92 MB +176 kB(+10.09%)
< Initial CSS 16.8 kB 30.5 kB +13.7 kB(+81.83%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 39 45 +6
< Chunks 37 39 +2
< Packages 132 139 +7
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master …sort-all-page +/- ##
===================================================================
= Bundle 16.6 kB 16.6 kB
= Initial JS 16.6 kB 16.6 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
himself65
approved these changes
May 15, 2023
himself65
pushed a commit
that referenced
this pull request
May 15, 2023
Brooooooklyn
pushed a commit
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1752
Screen.Recording.2023-05-15.at.5.12.29.PM.mov
The implementation of function
useSorterrefers to the following libs: