Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): init notification center #2426

Merged
merged 34 commits into from
May 26, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented May 17, 2023

Fixes: #1870

2023-05-25.18.27.36.mov

@codesandbox
Copy link

codesandbox bot commented May 17, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@himself65 himself65 temporarily deployed to development May 17, 2023 23:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:30 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 3:47am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 3:47am

@himself65 himself65 temporarily deployed to development May 17, 2023 23:30 — with GitHub Actions Inactive
@himself65 himself65 marked this pull request as draft May 17, 2023 23:30
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3a16e40
Status: ✅  Deploy successful!
Preview URL: https://9b44b558.affine.pages.dev
Branch Preview URL: https://himself65-0517-notification.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development May 17, 2023 23:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:31 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:34 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 14.20% and project coverage change: -1.51 ⚠️

Comparison is base (3b8f2c1) 72.61% compared to head (3a16e40) 71.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
- Coverage   72.61%   71.10%   -1.51%     
==========================================
  Files         317      319       +2     
  Lines        7054     7230     +176     
  Branches     1145     1189      +44     
==========================================
+ Hits         5122     5141      +19     
- Misses       1733     1887     +154     
- Partials      199      202       +3     
Flag Coverage Δ
e2etest 66.37% <ø> (+0.02%) ⬆️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 47.43% <ø> (-0.42%) ⬇️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 51.10% <14.20%> (-4.16%) ⬇️
unittest 37.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onent/src/components/notification-center/index.tsx 7.48% <7.48%> (ø)
.../src/components/notification-center/index.jotai.ts 48.27% <48.27%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development May 17, 2023 23:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:37 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 23:37 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 17, 2023 23:38 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 17, 2023 23:42 Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 02:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 02:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 02:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 02:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 02:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 02:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 02:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 02:51 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 26, 2023 02:54 Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:22 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:25 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 26, 2023 03:27 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 26, 2023 03:42 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 26, 2023 03:47 Inactive
@himself65 himself65 merged commit f4b3830 into master May 26, 2023
@himself65 himself65 deleted the himself65/0517-notification-center branch May 26, 2023 06:32
himself65 added a commit that referenced this pull request May 26, 2023
Co-authored-by: JimmFly <yangjinfei001@gmail.com>
himself65 added a commit that referenced this pull request Jun 2, 2023
Co-authored-by: JimmFly <yangjinfei001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

New toast design​
2 participants