Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove outline plugin and layout atom #5326

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 18, 2023

@affine/outline is no longer used, this PR deletes this plugin and deletes the code that is no longer used

Copy link

graphite-app bot commented Dec 18, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:plugin app:core labels Dec 18, 2023
@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch from 2f97ff2 to d365fdf Compare December 18, 2023 08:43
@github-actions github-actions bot added app:electron Related to electron app test Related to test cases labels Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a10aeca) 59.52% compared to head (05025bf) 59.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5326      +/-   ##
==========================================
+ Coverage   59.52%   59.56%   +0.04%     
==========================================
  Files         517      517              
  Lines       22248    22221      -27     
  Branches     1984     1979       -5     
==========================================
- Hits        13243    13236       -7     
+ Misses       8664     8643      -21     
- Partials      341      342       +1     
Flag Coverage Δ
e2e-plugin-test 39.81% <ø> (+0.04%) ⬆️
server-test 69.61% <ø> (ø)
unittest 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch 2 times, most recently from 9e18f5f to b830973 Compare December 18, 2023 13:16
@github-actions github-actions bot added the docs Improvements or additions to documentation label Dec 18, 2023
@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch from b830973 to 93892ad Compare December 19, 2023 02:58
@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch 2 times, most recently from 7221f5b to 63786e3 Compare December 19, 2023 09:12
@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch 2 times, most recently from 3de577d to e1eca53 Compare December 20, 2023 04:56
@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch from e1eca53 to 31129d0 Compare December 21, 2023 03:15
Copy link

graphite-app bot commented Dec 25, 2023

Merge activity

@affine/outline is no longer used, this PR deletes this plugin and deletes the code that is no longer used
@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch from 31129d0 to 05025bf Compare December 25, 2023 03:24
@graphite-app graphite-app bot merged commit 05025bf into canary Dec 25, 2023
35 of 37 checks passed
@graphite-app graphite-app bot deleted the eyhn/refactor/remove/outline-plugin branch December 25, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app docs Improvements or additions to documentation mod:infra Environment related issues and discussions mod:plugin test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants