-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(infra): move currentPageAtom to core #5332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
github-actions
bot
added
mod:infra
Environment related issues and discussions
mod:store
app:core
mod:sdk
labels
Dec 19, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #5332 +/- ##
=======================================
Coverage 59.55% 59.56%
=======================================
Files 512 512
Lines 22193 22194 +1
Branches 1977 1977
=======================================
+ Hits 13218 13219 +1
Misses 8634 8634
Partials 341 341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EYHN
force-pushed
the
eyhn/refactor/move-atom
branch
from
December 19, 2023 03:43
9565fe9
to
e47fc76
Compare
EYHN
changed the base branch from
eyhn/feat/di
to
eyhn/refactor/remove-adapter
December 19, 2023 03:43
EYHN
force-pushed
the
eyhn/refactor/remove-adapter
branch
from
December 19, 2023 08:39
3549261
to
84078be
Compare
EYHN
force-pushed
the
eyhn/refactor/move-atom
branch
from
December 19, 2023 08:39
e47fc76
to
d54fbaf
Compare
EYHN
force-pushed
the
eyhn/refactor/remove-adapter
branch
from
December 19, 2023 09:12
84078be
to
50fe030
Compare
EYHN
force-pushed
the
eyhn/refactor/move-atom
branch
from
December 19, 2023 09:12
d54fbaf
to
70e6254
Compare
EYHN
force-pushed
the
eyhn/refactor/remove-adapter
branch
from
December 20, 2023 04:56
50fe030
to
1bedbf9
Compare
EYHN
force-pushed
the
eyhn/refactor/move-atom
branch
from
December 20, 2023 04:57
70e6254
to
2ab1f97
Compare
EYHN
force-pushed
the
eyhn/refactor/remove-adapter
branch
from
December 21, 2023 03:15
1bedbf9
to
6a221e8
Compare
EYHN
force-pushed
the
eyhn/refactor/move-atom
branch
from
December 21, 2023 03:15
2ab1f97
to
14a8275
Compare
pengx17
approved these changes
Dec 25, 2023
Merge activity
|
EYHN
force-pushed
the
eyhn/refactor/remove-adapter
branch
from
December 25, 2023 03:25
6a221e8
to
170bfab
Compare
Remove `currentPageAtom` from `infra` to `frontend/core.`
EYHN
force-pushed
the
eyhn/refactor/remove-adapter
branch
from
December 25, 2023 03:34
170bfab
to
e1bd13a
Compare
EYHN
force-pushed
the
eyhn/refactor/move-atom
branch
from
December 25, 2023 03:35
14a8275
to
9493bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app:core
app:electron
Related to electron app
mod:infra
Environment related issues and discussions
mod:sdk
mod:store
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
currentPageAtom
frominfra
tofrontend/core.