Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(infra): move currentPageAtom to core #5332

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 19, 2023

Remove currentPageAtom from infra to frontend/core.

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:store app:core mod:sdk labels Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1bd13a) 59.55% compared to head (9493bd9) 59.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5332   +/-   ##
=======================================
  Coverage   59.55%   59.56%           
=======================================
  Files         512      512           
  Lines       22193    22194    +1     
  Branches     1977     1977           
=======================================
+ Hits        13218    13219    +1     
  Misses       8634     8634           
  Partials      341      341           
Flag Coverage Δ
e2e-plugin-test 39.75% <100.00%> (+<0.01%) ⬆️
server-test 69.61% <ø> (ø)
unittest 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the app:electron Related to electron app label Dec 19, 2023
@EYHN EYHN changed the base branch from eyhn/feat/di to eyhn/refactor/remove-adapter December 19, 2023 03:43
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 3549261 to 84078be Compare December 19, 2023 08:39
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 84078be to 50fe030 Compare December 19, 2023 09:12
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 50fe030 to 1bedbf9 Compare December 20, 2023 04:56
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 1bedbf9 to 6a221e8 Compare December 21, 2023 03:15
Copy link

graphite-app bot commented Dec 25, 2023

Merge activity

@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 6a221e8 to 170bfab Compare December 25, 2023 03:25
Remove `currentPageAtom` from `infra` to `frontend/core.`
@EYHN EYHN changed the base branch from eyhn/refactor/remove-adapter to canary December 25, 2023 03:43
@graphite-app graphite-app bot merged commit 9493bd9 into canary Dec 25, 2023
33 checks passed
@graphite-app graphite-app bot deleted the eyhn/refactor/move-atom branch December 25, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:infra Environment related issues and discussions mod:sdk mod:store
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants