refactor(component): adjust active editor atom #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #5457 +/- ##
=======================================
Coverage 67.04% 67.04%
=======================================
Files 199 199
Lines 15692 15692
Branches 1115 1115
=======================================
Hits 10521 10521
Misses 5011 5011
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Dec 29, 2023
EYHN
force-pushed
the
eyhn/refactor/move-editor
branch
from
c91c225
to
5291a0c
Compare
EYHN
changed the title
Brooooooklyn
approved these changes
Jan 2, 2024
pengx17
approved these changes
Jan 2, 2024
EYHN
force-pushed
the
eyhn/refactor/move-editor
branch
from
5291a0c
to
50b26b2
Compare
JimmFly
approved these changes
Jan 2, 2024
Merge activity
|
before: set global `blocksuiteEditorAtom` state in `<BlocksuiteEditorImpl />` after: Rename `blocksuiteEditorAtom` to `activeBlocksuiteEditorAtom` And move the logic of setting this atom to `<PageDetailEditor />`. benefit: * make BlocksuiteEditor pure * keep @toeverything/component clear * Clarify the purpose of `activeBlocksuiteEditorAtom`
EYHN
force-pushed
the
eyhn/refactor/move-editor
branch
from
50b26b2
to
6844b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
set global
blocksuiteEditorAtomstate in<BlocksuiteEditorImpl />after:
Rename
blocksuiteEditorAtomtoactiveBlocksuiteEditorAtomAnd move the logic of setting this atom to
<PageDetailEditor />.benefit:
activeBlocksuiteEditorAtom