Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): move workspace atoms to core #5459

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 29, 2023

@affine/workspace/atom -> @affine/core/modules/workspace

Copy link

graphite-app bot commented Dec 29, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@github-actions github-actions bot added mod:store test Related to test cases app:core labels Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b217e6) 67.04% compared to head (9d0b3b4) 67.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5459   +/-   ##
=======================================
  Coverage   67.04%   67.04%           
=======================================
  Files         199      199           
  Lines       15692    15692           
  Branches     1115     1115           
=======================================
  Hits        10521    10521           
  Misses       5011     5011           
  Partials      160      160           
Flag Coverage Δ
server-test 69.73% <ø> (ø)
unittest 54.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jan 2, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/refactor/move-hooks-to-core branch from 95c8578 to 5d7cc17 Compare January 2, 2024 07:54
@EYHN EYHN force-pushed the eyhn/refactor/move-workspace-atom branch from dfe34f3 to 83ade6e Compare January 2, 2024 07:54
@EYHN EYHN force-pushed the eyhn/refactor/move-hooks-to-core branch from 5d7cc17 to 4b217e6 Compare January 2, 2024 08:05
@EYHN EYHN changed the base branch from eyhn/refactor/move-hooks-to-core to canary January 2, 2024 09:18
@EYHN EYHN force-pushed the eyhn/refactor/move-workspace-atom branch from 83ade6e to d653a1b Compare January 2, 2024 09:57
@affine/workspace/atom -> @affine/core/modules/workspace
@EYHN EYHN force-pushed the eyhn/refactor/move-workspace-atom branch from d653a1b to 9d0b3b4 Compare January 2, 2024 10:06
@graphite-app graphite-app bot merged commit 9d0b3b4 into canary Jan 2, 2024
36 checks passed
@graphite-app graphite-app bot deleted the eyhn/refactor/move-workspace-atom branch January 2, 2024 10:15
@EYHN EYHN mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:store test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants