-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): refactor atom to use di #5831
Conversation
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
1ad0592
to
909b033
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ad9b030. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #5831 +/- ##
==========================================
- Coverage 64.31% 64.19% -0.13%
==========================================
Files 360 362 +2
Lines 19969 19987 +18
Branches 1705 1707 +2
==========================================
- Hits 12844 12831 -13
- Misses 6904 6934 +30
- Partials 221 222 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8c4811d
to
6cf2890
Compare
packages/frontend/core/src/components/affine/affine-error-boundary/error-basic/info-logger.tsx
Show resolved
Hide resolved
packages/frontend/core/src/hooks/affine/use-register-blocksuite-editor-commands.tsx
Show resolved
Hide resolved
f947cf3
to
df2ee85
Compare
df2ee85
to
068f472
Compare
426045f
to
dc7ace4
Compare
dc7ace4
to
de11d21
Compare
PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here. CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
Merge activity
|
To support multiple instances, this PR removes some atoms and implements them using the new DI system. removed atom - `pageSettingsAtom` - `currentPageIdAtom` - `currentModeAtom`
de11d21
to
ad9b030
Compare
To support multiple instances, this PR removes some atoms and implements them using the new DI system.
removed atom
pageSettingsAtom
currentPageIdAtom
currentModeAtom