Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): refactor atom to use di #5831

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Feb 18, 2024

To support multiple instances, this PR removes some atoms and implements them using the new DI system.

removed atom

  • pageSettingsAtom
  • currentPageIdAtom
  • currentModeAtom

Copy link

graphite-app bot commented Feb 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Feb 18, 2024

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:store test Related to test cases app:core labels Feb 18, 2024
@EYHN EYHN marked this pull request as ready for review February 18, 2024 16:52
Copy link

nx-cloud bot commented Feb 19, 2024

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 64.19%. Comparing base (0dabb08) to head (ad9b030).

Files Patch % Lines
packages/common/infra/src/initialization/index.ts 15.78% 32 Missing ⚠️
packages/common/infra/src/page/record.ts 28.57% 15 Missing ⚠️
...ackages/frontend/workspace-impl/src/local-state.ts 0.00% 5 Missing ⚠️
packages/common/infra/src/livedata/react.ts 0.00% 2 Missing and 2 partials ⚠️
...ontend/core/src/modules/infra-web/storage/index.ts 0.00% 3 Missing ⚠️
packages/common/infra/src/page/manager.ts 75.00% 1 Missing and 1 partial ⚠️
packages/common/infra/src/page/page.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5831      +/-   ##
==========================================
- Coverage   64.31%   64.19%   -0.13%     
==========================================
  Files         360      362       +2     
  Lines       19969    19987      +18     
  Branches     1705     1707       +2     
==========================================
- Hits        12844    12831      -13     
- Misses       6904     6934      +30     
- Partials      221      222       +1     
Flag Coverage Δ
server-test 71.20% <ø> (ø)
unittest 44.70% <36.36%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/remove/atom branch 2 times, most recently from f947cf3 to df2ee85 Compare February 21, 2024 07:28
@EYHN EYHN force-pushed the eyhn/remove/atom branch 3 times, most recently from 426045f to dc7ace4 Compare February 26, 2024 03:52
Copy link

PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here.

CI Failure Feedback

Action: 3, 2, 1 Launch

Failed stage: Run exit 1 [❌]

Failure summary:

The action failed due to a process exiting with exit code 1. This typically indicates a generic
error in the execution of a command or script within the job. The specific cause of the error is not
detailed in the provided log, so further investigation into the steps executed prior to the error
would be necessary to pinpoint the exact issue.

Relevant error logs:
1:  Job defined at: toeverything/AFFiNE/.github/workflows/build-test.yml@refs/pull/5831/merge
2:  Waiting for a runner to pick up this job...
...

45:  APP_NAME: affine
46:  AFFINE_ENV: dev
47:  COVERAGE: true
48:  MACOSX_DEPLOYMENT_TARGET: 10.13
49:  NX_CLOUD_ACCESS_TOKEN: ***
50:  PLAYWRIGHT_BROWSERS_PATH: /home/runner/work/AFFiNE/AFFiNE/node_modules/.cache/ms-playwright
51:  DEPLOYMENT_TYPE: affine
52:  ##[endgroup]
53:  ##[error]Process completed with exit code 1.

✨ CI feedback usage guide:

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

  • Failed stage
  • Failed test name
  • Failure summary
  • Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

  • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
  • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
  • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
  • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.

See more information about the checks tool in the docs.

Copy link

graphite-app bot commented Feb 27, 2024

Merge activity

To support multiple instances, this PR removes some atoms and implements them using the new DI system.

removed atom

- `pageSettingsAtom`
- `currentPageIdAtom`
- `currentModeAtom`
@graphite-app graphite-app bot merged commit ad9b030 into canary Feb 27, 2024
34 of 36 checks passed
@graphite-app graphite-app bot deleted the eyhn/remove/atom branch February 27, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions mod:store mod:workspace-impl test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants