-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): workbench system #5837
Conversation
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 73b0dc7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #5837 +/- ##
==========================================
- Coverage 64.25% 63.95% -0.30%
==========================================
Files 362 364 +2
Lines 19967 20033 +66
Branches 1706 1713 +7
==========================================
- Hits 12830 12813 -17
- Misses 6918 7001 +83
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
77b56b0
to
b23fb5a
Compare
2c5d31a
to
54680dc
Compare
b23fb5a
to
c772225
Compare
cf5ce5c
to
ae117d8
Compare
c772225
to
5afe074
Compare
ae117d8
to
cd272a9
Compare
5afe074
to
ff6dd5b
Compare
cd272a9
to
4cb223e
Compare
ff6dd5b
to
690972c
Compare
4cb223e
to
2281dbc
Compare
690972c
to
189ce25
Compare
391d326
to
93f5201
Compare
packages/frontend/core/src/modules/workbench/browser-adapter.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we may need to add some new baseline e2e tests for this stack of PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
93f5201
to
0c880f2
Compare
189ce25
to
28e66b1
Compare
0c880f2
to
a933b12
Compare
PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here. CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here. CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here. CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here. CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here. CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
a933b12
to
8284da4
Compare
PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here. CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
28e66b1
to
5cd488f
Compare
8284da4
to
73b0dc7
Compare
Workbench
router