Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove collection atom #5832

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Feb 18, 2024

No description provided.

Copy link

graphite-app bot commented Feb 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Feb 18, 2024

@EYHN EYHN marked this pull request as ready for review February 18, 2024 16:52
@github-actions github-actions bot added mod:store test Related to test cases app:core labels Feb 18, 2024
Copy link

nx-cloud bot commented Feb 18, 2024

@EYHN EYHN force-pushed the eyhn/refactor/collection branch 4 times, most recently from 8bf10af to 50b76a0 Compare February 19, 2024 06:05
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.16%. Comparing base (ad9b030) to head (5cd488f).

Files Patch % Lines
...es/frontend/core/src/modules/collection/service.ts 0.00% 3 Missing ⚠️
...ges/frontend/core/src/hooks/use-navigate-helper.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5832      +/-   ##
==========================================
- Coverage   64.19%   64.16%   -0.04%     
==========================================
  Files         362      362              
  Lines       19987    19967      -20     
  Branches     1707     1705       -2     
==========================================
- Hits        12831    12811      -20     
- Misses       6934     6937       +3     
+ Partials      222      219       -3     
Flag Coverage Δ
server-test 71.20% <ø> (ø)
unittest 44.49% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/remove/atom branch 3 times, most recently from df2ee85 to 068f472 Compare February 21, 2024 09:42
@EYHN EYHN force-pushed the eyhn/remove/atom branch 2 times, most recently from 426045f to dc7ace4 Compare February 26, 2024 03:51
Copy link

PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here.

CI Failure Feedback

Action: 3, 2, 1 Launch

Failed stage: Run exit 1 [❌]

Failure summary:

The action failed due to the process completing with exit code 1. This typically indicates a generic
error in the execution of the job defined in .github/workflows/build-test.yml. The exact cause of
the failure is not specified in the provided log, so further investigation into the steps executed
within this job is necessary to pinpoint the specific issue.

Relevant error logs:
1:  Job defined at: toeverything/AFFiNE/.github/workflows/build-test.yml@refs/pull/5832/merge
2:  Waiting for a runner to pick up this job...
...

45:  APP_NAME: affine
46:  AFFINE_ENV: dev
47:  COVERAGE: true
48:  MACOSX_DEPLOYMENT_TARGET: 10.13
49:  NX_CLOUD_ACCESS_TOKEN: ***
50:  PLAYWRIGHT_BROWSERS_PATH: /home/runner/work/AFFiNE/AFFiNE/node_modules/.cache/ms-playwright
51:  DEPLOYMENT_TYPE: affine
52:  ##[endgroup]
53:  ##[error]Process completed with exit code 1.

✨ CI feedback usage guide:

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

  • Failed stage
  • Failed test name
  • Failure summary
  • Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

  • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
  • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
  • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
  • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.

See more information about the checks tool in the docs.

Copy link

graphite-app bot commented Feb 27, 2024

Merge activity

@EYHN EYHN changed the base branch from eyhn/remove/atom to canary February 27, 2024 04:01
@graphite-app graphite-app bot merged commit 5cd488f into canary Feb 27, 2024
34 checks passed
@graphite-app graphite-app bot deleted the eyhn/refactor/collection branch February 27, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:store test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants