Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable rxjs/finnish #6276

Merged
merged 1 commit into from
Mar 24, 2024
Merged

style: enable rxjs/finnish #6276

merged 1 commit into from
Mar 24, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 23, 2024

chore(infra): use finnish notation for observables

do rename

Copy link

graphite-app bot commented Mar 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN marked this pull request as ready for review March 23, 2024 14:02
@github-actions github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app app:server test Related to test cases labels Mar 23, 2024
Copy link
Member Author

EYHN commented Mar 23, 2024

Copy link

nx-cloud bot commented Mar 23, 2024

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 39.71292% with 126 lines in your changes are missing coverage. Please review.

Project coverage is 60.05%. Comparing base (c6676fd) to head (2b42a75).

Files Patch % Lines
...d/core/src/modules/workbench/entities/workbench.ts 0.00% 27 Missing ⚠️
...ages/frontend/core/src/modules/tag/entities/tag.ts 0.00% 11 Missing ⚠️
...kages/frontend/core/src/modules/tag/service/tag.ts 0.00% 11 Missing ⚠️
...rc/modules/right-sidebar/entities/right-sidebar.ts 0.00% 9 Missing ⚠️
packages/common/infra/src/livedata/index.ts 83.33% 5 Missing and 1 partial ⚠️
.../core/src/modules/navigation/entities/navigator.ts 0.00% 6 Missing ⚠️
packages/common/infra/src/initialization/index.ts 0.00% 4 Missing ⚠️
...ges/common/infra/src/workspace/engine/doc/index.ts 60.00% 4 Missing ⚠️
...ontend/core/src/modules/workbench/entities/view.ts 0.00% 4 Missing ⚠️
...re/src/modules/workbench/view/split-view/panel.tsx 0.00% 4 Missing ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6276      +/-   ##
==========================================
- Coverage   60.14%   60.05%   -0.09%     
==========================================
  Files         507      507              
  Lines       23493    23496       +3     
  Branches     2151     2150       -1     
==========================================
- Hits        14129    14110      -19     
- Misses       9103     9125      +22     
  Partials      261      261              
Flag Coverage Δ
server-test 70.45% <0.00%> (-0.12%) ⬇️
unittest 38.59% <40.09%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN changed the title chore(infra): use finnish notation for observables style: enable rxjs/finnish Mar 23, 2024
Copy link

graphite-app bot commented Mar 24, 2024

Merge activity

chore(infra): use finnish notation for observables

do rename
@graphite-app graphite-app bot merged commit 2b42a75 into canary Mar 24, 2024
38 of 40 checks passed
@graphite-app graphite-app bot deleted the eyhn/chore/finnish branch March 24, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app app:server mod:infra Environment related issues and discussions test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants