Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): livedata effect #6281

Merged
merged 1 commit into from
Mar 25, 2024
Merged

feat(infra): livedata effect #6281

merged 1 commit into from
Mar 25, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 23, 2024

No description provided.

Copy link

graphite-app bot commented Mar 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN marked this pull request as ready for review March 23, 2024 17:32
@EYHN EYHN mentioned this pull request Mar 23, 2024
@github-actions github-actions bot added mod:infra Environment related issues and discussions test Related to test cases labels Mar 23, 2024
Copy link
Member Author

EYHN commented Mar 23, 2024

Copy link

nx-cloud bot commented Mar 23, 2024

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 81.70732% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 60.04%. Comparing base (f2adbda) to head (a8cd157).

Files Patch % Lines
packages/common/infra/src/livedata/livedata.ts 83.82% 16 Missing and 6 partials ⚠️
packages/common/infra/src/livedata/effect/index.ts 45.45% 6 Missing ⚠️
packages/common/infra/src/livedata/ops.ts 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6281      +/-   ##
==========================================
- Coverage   60.10%   60.04%   -0.07%     
==========================================
  Files         507      509       +2     
  Lines       23481    23512      +31     
  Branches     2151     2150       -1     
==========================================
+ Hits        14113    14117       +4     
- Misses       9107     9134      +27     
  Partials      261      261              
Flag Coverage Δ
server-test 70.43% <ø> (-0.12%) ⬇️
unittest 38.69% <81.70%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share some thoughts on effect design?

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share some thoughts on effect design?

@EYHN EYHN force-pushed the eyhn/chore/import-no-duplicates branch from aa00fa4 to 17d17fc Compare March 25, 2024 03:17
@EYHN EYHN force-pushed the eyhn/chore/import-no-duplicates branch from 17d17fc to f2adbda Compare March 25, 2024 03:57
@EYHN EYHN changed the base branch from eyhn/chore/import-no-duplicates to canary March 25, 2024 05:42
@EYHN EYHN force-pushed the eyhn/feat/effect branch 2 times, most recently from 2530fa2 to 92b83b3 Compare March 25, 2024 05:48
Copy link
Member Author

EYHN commented Mar 25, 2024

Can you please share some thoughts on effect design?

Main reference https://sigi.how/en/basic/effects
I guess we can see if it's practical later

@EYHN EYHN requested a review from pengx17 March 25, 2024 05:54
Copy link

graphite-app bot commented Mar 25, 2024

Merge activity

@graphite-app graphite-app bot merged commit a8cd157 into canary Mar 25, 2024
38 of 40 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/effect branch March 25, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants