Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): define runtimeConfig in esbuild #6287

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 24, 2024

No description provided.

Copy link

graphite-app bot commented Mar 24, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Mar 24, 2024

@github-actions github-actions bot added the app:electron Related to electron app label Mar 24, 2024
@EYHN EYHN marked this pull request as ready for review March 24, 2024 14:38
Copy link

nx-cloud bot commented Mar 24, 2024

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.04%. Comparing base (d59e138) to head (b93871f).

Additional details and impacted files
@@              Coverage Diff               @@
##           eyhn/fix/test    #6287   +/-   ##
==============================================
  Coverage          60.04%   60.04%           
==============================================
  Files                507      507           
  Lines              23492    23492           
  Branches            2150     2150           
==============================================
  Hits               14105    14105           
  Misses              9126     9126           
  Partials             261      261           
Flag Coverage Δ
server-test 70.45% <ø> (ø)
unittest 38.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 25, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/feat/electron-runtime branch from 394a483 to b93871f Compare March 25, 2024 03:56
@EYHN EYHN changed the base branch from eyhn/fix/test to canary March 25, 2024 05:40
@graphite-app graphite-app bot merged commit b93871f into canary Mar 25, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/electron-runtime branch March 25, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app mod:env
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants