Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add chat onboarding entry #7161

Merged
merged 1 commit into from
May 30, 2024

Conversation

regischen
Copy link
Contributor

No description provided.

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 5:24am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 5:24am

Copy link

graphite-app bot commented May 28, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @regischen and the rest of your teammates on Graphite Graphite

@regischen regischen changed the title feat(presets): add chat onboarding enry feat(presets): add chat onboarding entry May 28, 2024
@regischen regischen requested a review from CatsJuice May 28, 2024 14:06
@regischen regischen marked this pull request as ready for review May 28, 2024 14:06
@regischen regischen requested a review from pengx17 May 30, 2024 01:23
@@ -84,6 +85,8 @@ export class AIProvider {
engine: BlockSuitePresets.AIPhotoEngineService
): void;

static provide(id: 'onboarding', fn: (value: boolean) => void): void;
Copy link
Collaborator

@Saul-Mirone Saul-Mirone May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add onboarding to AIActions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After that, if we can move the AI code to AFFiNE, then this short-term processing is acceptable to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

Copy link

graphite-app bot commented May 30, 2024

Merge activity

@graphite-app graphite-app bot merged commit dfd9f0e into master May 30, 2024
19 checks passed
@graphite-app graphite-app bot deleted the feat-add-chat-onboarding-entry branch May 30, 2024 05:31
regischen added a commit to toeverything/AFFiNE that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants