-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edgeless): edgeless earser tool #3126
Conversation
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
If we incorporate transparency into CRDT, would there be any need for an additional view layer? |
It's definite that transparency would be into CRDT in the future. |
I understand that there might be such an intermediate state, but I'm unsure if it requires adding a global code hierarchy. Would placing this intermediate state as a field within the element suffice for this purpose? My main concern is whether the view would overlap with the existing responsibilities of the surface since both essentially involve CRUD operations on whiteboard elements. Can you provide other examples where this intermediate state is necessary? |
the view is not involved with crdt operations. right? Screen.Recording.2023-06-15.at.18.25.12.movif in the future, we have mindmap. When we drag one child element to change it's position. I think there is a middle state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should wait for #3118
8c2012d
to
5deb94f
Compare
8a52160
to
cf0afda
Compare
cf0afda
to
697408d
Compare
* master: feat(edgeless): support manage note index and hidden state (toeverything#3177) feat(edgeless): keep brush state in one session (toeverything#3161) feat(edgeless): edgeless earser tool (toeverything#3126) fix(store): waitForLoaded timeout if doc loaded (toeverything#3176) feat(block-std): add block spec (toeverything#3175) feat: the mouse pointer can become a gesture when dragging (toeverything#3174) fix: text cannot be selected in edit mode (toeverything#3173) refactor(database): decouple table render from model (toeverything#3151) fix: handling backspace key press for cursor transition from paragraph to page title (toeverything#3148) ci: add `lit-analyzer` (toeverything#3168) refactor: use transform instead of position on selected-blocks (toeverything#3166) feat(block-std): init package and move event dispatcher to std (toeverything#3164) feat(store): let user control subdoc load timing after page meta added (toeverything#3157) fix(virgo): handle the deletion of selected text (toeverything#3155) refactor(blocks): make elements as prop of surface block (toeverything#3156) chore: bump lock file version (toeverything#3154) refactor(phasor): prevent `SurfaceElement` export (toeverything#3150)
closes #2943