Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edgeless): keep brush state in one session #3161

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

regischen
Copy link
Member

closes #2649

@codesandbox
Copy link

codesandbox bot commented Jun 19, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 1:17pm
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 1:17pm

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about migrating the viewport state to session storage altogether?

@regischen
Copy link
Member Author

How about migrating the viewport state to session storage altogether?

okay

@doodlewind doodlewind deleted the feat-keep-brush-state branch June 20, 2023 13:25
fundon added a commit to fundon/blocksuite that referenced this pull request Jun 20, 2023
* master:
  feat(edgeless): support manage note index and hidden state (toeverything#3177)
  feat(edgeless): keep brush state in one session (toeverything#3161)
  feat(edgeless): edgeless earser tool (toeverything#3126)
  fix(store): waitForLoaded timeout if doc loaded (toeverything#3176)
  feat(block-std): add block spec (toeverything#3175)
  feat: the mouse pointer can become a gesture when dragging (toeverything#3174)
  fix: text cannot be selected in edit mode (toeverything#3173)
  refactor(database): decouple table render from model (toeverything#3151)
  fix: handling backspace key press for cursor transition from paragraph to page title (toeverything#3148)
  ci: add `lit-analyzer` (toeverything#3168)
  refactor: use transform instead of position on selected-blocks (toeverything#3166)
  feat(block-std): init package and move event dispatcher to std (toeverything#3164)
  feat(store): let user control subdoc load timing after page meta added (toeverything#3157)
  fix(virgo): handle the deletion of selected text (toeverything#3155)
  refactor(blocks): make elements as prop of surface block (toeverything#3156)
  chore: bump lock file version (toeverything#3154)
  refactor(phasor): prevent `SurfaceElement` export (toeverything#3150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Support keeping color, thickness and configs in edgeless pen tool
2 participants