Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for indenting and unindenting multi-level blocks #3127

Merged
merged 9 commits into from
Jun 16, 2023
Merged

feat: support for indenting and unindenting multi-level blocks #3127

merged 9 commits into from
Jun 16, 2023

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Jun 15, 2023 •
edited

To close #2862

  1. Current implementation of intenation.
indent-multi-level-blocks
  • Unindentation of multi-level blocks
  • Add E2E Test

@codesandbox
Copy link

codesandbox bot commented Jun 15, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jun 15, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 11:28am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 11:28am

@donteatfriedrice
Copy link
Member Author

donteatfriedrice commented Jun 15, 2023 •
edited

  1. Current effects for indentation:
indent-multi-level-blocks.mov

@donteatfriedrice donteatfriedrice marked this pull request as draft June 15, 2023 16:57
@donteatfriedrice donteatfriedrice changed the title feat: support for indenting multi-level blocks feat: support for indenting and unindenting multi-level blocks Jun 15, 2023
@donteatfriedrice
Copy link
Member Author

  1. Current effects for unindentation:
unindentation.mov

@donteatfriedrice donteatfriedrice marked this pull request as ready for review June 16, 2023 06:33
@donteatfriedrice
Copy link
Member Author

@doodlewind In the CI process, it seems that the error below often occurs, is there any way to solve it?

Screenshot 2023-06-16 at 16 16 53

@doodlewind
Copy link
Member

Retry! 😈

doodlewind
doodlewind approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty neat, thanks!

@doodlewind doodlewind enabled auto-merge (squash) June 16, 2023 11:27
@doodlewind doodlewind merged commit 6448d9e into toeverything:master Jun 16, 2023
18 checks passed
fundon added a commit to fundon/blocksuite that referenced this pull request Jun 17, 2023
@fundon
Merge branch 'master' into 0614-support-DnD-images-from-outside-into-…
2e3ffc5 
…editor

* master:
  refactor: `frame` -> `note` (toeverything#3144)
  feat(edgeless): support drag canvas with middle button of mouse (toeverything#3146)
  fix: notion import error on todo (toeverything#3110)
  feat: support for indenting and unindenting multi-level blocks (toeverything#3127)
  fix: can not drop bookmark with new frame in edgeless from block-hub (toeverything#3145)
@donteatfriedrice donteatfriedrice deleted the fix/using-tab-to-indent-multiple-lists-and-shift+tab-to-unindent branch July 21, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@donteatfriedrice donteatfriedrice

Labels
None yet
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support using tab to indent multiple highlighted list lines with different indent levels
2 participants
@donteatfriedrice @doodlewind