Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(blocks): frame -> note #3144

Merged
merged 6 commits into from
Jun 16, 2023
Merged

refactor(blocks): frame -> note #3144

merged 6 commits into from
Jun 16, 2023

Conversation

Flrande
Copy link
Member

@Flrande Flrande commented Jun 16, 2023 •
edited
Loading

Close #2710

@codesandbox
Copy link

codesandbox bot commented Jun 16, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jun 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 5:15pm
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 5:15pm

@doodlewind doodlewind added the breaking Contains breaking change that must be addressed label Jun 16, 2023
doodlewind
doodlewind approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😈😈😈

@Flrande Flrande merged commit 720da7d into toeverything:master Jun 16, 2023
18 checks passed
@Flrande Flrande deleted the refactor/frame-note-0616 branch June 16, 2023 17:27
fundon added a commit to fundon/blocksuite that referenced this pull request Jun 17, 2023
@fundon
Merge branch 'master' into 0614-support-DnD-images-from-outside-into-…
2e3ffc5 
…editor

* master:
  refactor: `frame` -> `note` (toeverything#3144)
  feat(edgeless): support drag canvas with middle button of mouse (toeverything#3146)
  fix: notion import error on todo (toeverything#3110)
  feat: support for indenting and unindenting multi-level blocks (toeverything#3127)
  fix: can not drop bookmark with new frame in edgeless from block-hub (toeverything#3145)
@Saul-Mirone Saul-Mirone mentioned this pull request Jun 18, 2023
Closed
@Saul-Mirone Saul-Mirone changed the title refactor: frame -> note refactor(blocks): frame -> note Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@Flrande Flrande

Labels
breaking Contains breaking change that must be addressed
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from affine:frame to affine:note
2 participants
@Flrande @doodlewind