fix: console error exporting PNG/PDF in playground #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zuoxiaodong0815
changed the title
doodlewind
approved these changes
Jun 26, 2023
fourdim
reviewed
Jun 28, 2023
| import type { BaseBlockModel, Page } from '@blocksuite/store'; | ||
| import { Slot } from '@blocksuite/store'; | ||
| import { marked } from 'marked'; | ||
|
|
||
| import { xywhArrayToObject } from '../..//page-block/edgeless/utils.js'; |
There was a problem hiding this comment.
It seems that something is wrong here.
fourdim
added a commit
that referenced
this pull request
Jun 28, 2023
This fixes the error introduced in #3205.
fundon
added a commit
to fundon/blocksuite
that referenced
this pull request
Jun 29, 2023
…editor * master: (62 commits) fix: image resize after switch page mode (toeverything#3238) feat(edgeless): add index for other notes when selecting a note (toeverything#3235) feat: support import notion database (toeverything#3170) style: adjust checkbox style (toeverything#3240) fix: the incorrect import path (toeverything#3234) fix: console error exporting PNG/PDF in playground (toeverything#3205) feat(blocks): add page block service (toeverything#3232) refactor(edgeless): rename children container (toeverything#3231) fix: edgeless text error when importing from snapshot (toeverything#3229) refactor(blocks): split code (toeverything#3228) fix(store): handle resource load error when importing snapshot (toeverything#3227) feat: use human-readable name in code block (toeverything#3225) fix(store): snapshot import and export (toeverything#3223) fix(phasor): curveFitting should be enabled on ellipse (toeverything#3224) feat: support for adding tags to pages (toeverything#3203) fix(store): broadcast channel not defined (toeverything#3222) fix(store): bring back remove page for subdoc (toeverything#3221) fix(phasor): bound should be calculated using expand (toeverything#3220) refactor: migrate image resize manager to block level (toeverything#3218) feat(edgeless): support select element below the hollow shape (toeverything#3212) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3115
fix: console error exporting PNG/PDF.
fix: the pdf file is too big.
fix: checked that the images have been displayed.