feat(edgeless): support select element below the hollow shape #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doouding
added
mod:edgeless
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
doouding
changed the title
doodlewind
removed
mod:edgeless
|
Just saying that you don't have to add module and type labels to PRs, they are mainly for issues :) |
|
It seems break some tests. I'll fix them soon. |
doodlewind
approved these changes
Jun 26, 2023
fundon
added a commit
to fundon/blocksuite
that referenced
this pull request
Jun 29, 2023
…editor * master: (62 commits) fix: image resize after switch page mode (toeverything#3238) feat(edgeless): add index for other notes when selecting a note (toeverything#3235) feat: support import notion database (toeverything#3170) style: adjust checkbox style (toeverything#3240) fix: the incorrect import path (toeverything#3234) fix: console error exporting PNG/PDF in playground (toeverything#3205) feat(blocks): add page block service (toeverything#3232) refactor(edgeless): rename children container (toeverything#3231) fix: edgeless text error when importing from snapshot (toeverything#3229) refactor(blocks): split code (toeverything#3228) fix(store): handle resource load error when importing snapshot (toeverything#3227) feat: use human-readable name in code block (toeverything#3225) fix(store): snapshot import and export (toeverything#3223) fix(phasor): curveFitting should be enabled on ellipse (toeverything#3224) feat: support for adding tags to pages (toeverything#3203) fix(store): broadcast channel not defined (toeverything#3222) fix(store): bring back remove page for subdoc (toeverything#3221) fix(phasor): bound should be calculated using expand (toeverything#3220) refactor: migrate image resize manager to block level (toeverything#3218) feat(edgeless): support select element below the hollow shape (toeverything#3212) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2034
Sorry for the long wait. I spent some time investigating several open source projects to find a proper solution. However, I found that all of them require a lot of effort. I believe that we need an overall solution for this type of geometric problem (just like how excalidraw do it), but it may not be our top priority right now. So I just used some simple math and native APIs to fulfill our needs.