Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeless): note block supports auto complete panel #6591

Merged
merged 1 commit into from
Mar 31, 2024
Merged

feat(edgeless): note block supports auto complete panel #6591

merged 1 commit into from
Mar 31, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 27, 2024 •
edited

Closes: BS-97, BS-96, BS-89

Screen.Recording.2024-03-27.at.17.57.36.mov
Screen.Recording.2024-03-28.at.15.33.46.mov
Screen.Recording.2024-03-28.at.18.07.20.mov

@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 27, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@vercel Vercel
Copy link

vercel bot commented Mar 27, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ❌ Failed (Inspect) Mar 31, 2024 10:04am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2024 10:04am

@fundon Graphite App
Copy link
Contributor Author

fundon commented Mar 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch 2 times, most recently from fc0f8b7 to f7b5da8 Compare March 27, 2024 09:55
@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from f7b5da8 to cc1f83e Compare March 28, 2024 07:29
fundon
fundon commented Mar 28, 2024
View reviewed changes
packages/blocks/src/root-block/edgeless/components/auto-complete/edgeless-auto-complete.ts Outdated
@@ -258,10 +264,23 @@ export class EdgelessAutoComplete extends WithDisposable(LitElement) {

private _addConnector(source: Connection, target: Connection) {
const { service } = this.edgeless;

let strokeColor = '--affine-palette-line-grey';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--affine-palette-line-grey --affine-tag-gray

Can we standardize the naming of these?

@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from cc1f83e to f0b8958 Compare March 28, 2024 07:33
@hwangdev97
Copy link
Member

if not matched, i think we need use grey/gray color, not black 🤔

@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from f0b8958 to fc1b52a Compare March 28, 2024 08:09
@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from fc1b52a to b5d1146 Compare March 28, 2024 08:20
@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from b5d1146 to 750316c Compare March 28, 2024 08:40
@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from 750316c to 08529b5 Compare March 28, 2024 09:02
@fundon fundon marked this pull request as ready for review March 28, 2024 10:09
@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from b3925d7 to 54a7052 Compare March 28, 2024 10:11
@fundon
Copy link
Contributor Author

fundon commented Mar 29, 2024

Maybe we not inherit the width and height ratio of note? The shape looks a bit weird 🤔.

Yes, the width and height need some adjustment.

Saul-Mirone
Saul-Mirone requested changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from 54a7052 to 2ca6581 Compare March 29, 2024 02:31
@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from 21d24ca to 33ac3fe Compare March 29, 2024 05:42
@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch 2 times, most recently from d61635f to 74a8a8d Compare March 29, 2024 05:57
@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch from a7ba1fb to caaf74b Compare March 29, 2024 06:12
@fundon fundon force-pushed the 03_27-note-block-supports-auto-complete-panel branch 2 times, most recently from 306edef to 3a6de43 Compare March 29, 2024 14:25
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 31, 2024 •
edited

Merge activity

  • Mar 31, 6:00 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 31, 6:00 AM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • Mar 31, 6:08 AM EDT: Saul-Mirone merged this pull request with the Graphite merge queue.

@Saul-Mirone Saul-Mirone force-pushed the 03_27-note-block-supports-auto-complete-panel branch from 5afd6a9 to 04dd560 Compare March 31, 2024 10:01
@graphite-app graphite-app bot merged commit 04dd560 into master Mar 31, 2024
18 of 19 checks passed
@graphite-app graphite-app bot deleted the 03_27-note-block-supports-auto-complete-panel branch March 31, 2024 10:08
@EYHN EYHN mentioned this pull request Apr 3, 2024
Merged
darkskygit pushed a commit to toeverything/AFFiNE that referenced this pull request Apr 10, 2024
@EYHN
chore: bump blocksuite (#6448)
c92bec0 
## Features
- toeverything/blocksuite#6679 @pengx17
- toeverything/blocksuite#6620 @doouding
- toeverything/blocksuite#6602 @golok727
- toeverything/blocksuite#6661 @Flrande
- toeverything/blocksuite#6591 @fundon
- toeverything/blocksuite#6634 @golok727
- toeverything/blocksuite#6626 @regischen
- toeverything/blocksuite#6630 @Saul-Mirone
- toeverything/blocksuite#6605 @donteatfriedrice
- toeverything/blocksuite#6614 @zzj3720
- toeverything/blocksuite#6508 @doouding
- toeverything/blocksuite#6578 @donteatfriedrice
- toeverything/blocksuite#6572 @zzj3720
- toeverything/blocksuite#6571 @golok727
- toeverything/blocksuite#6573 @fundon
- toeverything/blocksuite#6580 @Flrande
- toeverything/blocksuite#6540 @golok727
- toeverything/blocksuite#6567 @Flrande
- toeverything/blocksuite#6565 @zzj3720
- toeverything/blocksuite#6561 @zzj3720

## Bugfix
- toeverything/blocksuite#6677 @donteatfriedrice
- toeverything/blocksuite#6681 @fundon
- toeverything/blocksuite#6673 @fundon
- toeverything/blocksuite#6652 @fundon
- toeverything/blocksuite#6641 @fourdim
- toeverything/blocksuite#6649 @golok727
- toeverything/blocksuite#6648 @doouding
- toeverything/blocksuite#6662 @Flrande
- toeverything/blocksuite#6659 @zkwolf
- toeverything/blocksuite#6644 @doouding
- toeverything/blocksuite#6633 @golok727
- toeverything/blocksuite#6632 @golok727
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6622 @RubaXa
- toeverything/blocksuite#6600 @fourdim
- toeverything/blocksuite#6617 @zzj3720
- toeverything/blocksuite#6618 @Flrande
- toeverything/blocksuite#6576 @fundon
- toeverything/blocksuite#6595 @fundon
- toeverything/blocksuite#6596 @zzj3720
- toeverything/blocksuite#6574 @fundon
- toeverything/blocksuite#6593 @Saul-Mirone
- toeverything/blocksuite#6588 @zzj3720
- toeverything/blocksuite#6590 @zzj3720
- toeverything/blocksuite#6589 @zzj3720
- toeverything/blocksuite#6584 @lawvs
- toeverything/blocksuite#6579 @fundon
- toeverything/blocksuite#6538 @golok727
- toeverything/blocksuite#6570 @zzj3720
- toeverything/blocksuite#6569 @zzj3720
- toeverything/blocksuite#6564 @zzj3720
- toeverything/blocksuite#6563 @zzj3720

## Refactor
- toeverything/blocksuite#6683 @doodlewind
- toeverything/blocksuite#6668 @Flrande
- toeverything/blocksuite#6635 @donteatfriedrice
- toeverything/blocksuite#6653 @fundon
- toeverything/blocksuite#6615 @Flrande
- toeverything/blocksuite#6534 @Saul-Mirone
- toeverything/blocksuite#6553 @golok727

## Misc
- chore(examples): cleanup types
- toeverything/blocksuite#6664 @fourdim
- toeverything/blocksuite#6657 @fourdim
- toeverything/blocksuite#6654 @fourdim
- toeverything/blocksuite#6587 @Saul-Mirone
- toeverything/blocksuite#6562 @donteatfriedrice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saul-Mirone Saul-Mirone Saul-Mirone approved these changes

@donteatfriedrice donteatfriedrice Awaiting requested review from donteatfriedrice

@doouding doouding Awaiting requested review from doouding

@doodlewind doodlewind Awaiting requested review from doodlewind

@hwangdev97 hwangdev97 Awaiting requested review from hwangdev97

@regischen regischen Awaiting requested review from regischen

Assignees
No one assigned
Labels
merge
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fundon @hwangdev97 @donteatfriedrice @Saul-Mirone