Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing scalafmt rules #292

Open
catostrophe opened this issue May 31, 2020 · 3 comments
Open

Consider changing scalafmt rules #292

catostrophe opened this issue May 31, 2020 · 3 comments
Labels
chore Repository maintenance

Comments

@catostrophe
Copy link
Member

I do support the need for a forced formatter in a project with many contributors, but the current ruleset is awful and doesn't work properly in IDEA (has some wrong fields).
@catostrophe catostrophe added the chore Repository maintenance label May 31, 2020
@catostrophe
Copy link
Member Author

@ReiReiRei attn

@ReiReiRei
Copy link
Contributor

@catostrophe do not mind. Rules had been set by @Odomontois so I have decided do not change them. Anyway, if rules are changed it meens a new large commit with reformated code. Anyway I think @catostrophe should create new issue for IDEA for better scalafmt support.

@Odomontois Odomontois mentioned this issue Jul 2, 2020
Merged
@catostrophe
Copy link
Member Author

I tried .scalafmt.conf from Izumi repo.
Liked the result, but I would suggest a few changes:

  • maxColumn = 120
  • drop newlines.alwaysBeforeCurlyBraceLambdaParams = true

@Odomontois Odomontois mentioned this issue Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Repository maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Odomontois @ReiReiRei @catostrophe