Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

ownable.sol #125

Closed
asmckinlay opened this issue Oct 3, 2018 · 2 comments
Closed

ownable.sol #125

asmckinlay opened this issue Oct 3, 2018 · 2 comments
Labels
enhancement New feature or request oracle Oracle related issue wallet

Comments

@asmckinlay
Copy link
Contributor

asmckinlay commented Oct 3, 2018 •
edited
Loading

in acceptOwnership() there's require(_newOwner != address(0), "owner cannot be set to 0x0000000000000000000000000000000000000000");. Shouldn't this line also exist in transferOwnership() for address _account?
@nostdm
Copy link
Contributor

nostdm commented Oct 4, 2018

It's unnecessary since by default the zero-value of an adress is 0x0... so if you set it to 0x0... you're not really doing anything. The key is to prevent the acceptance of the ownership when the address has a zero-value i.e. 0x0...

@draganm draganm added enhancement New feature or request oracle Oracle related issue wallet labels Oct 8, 2018
@nostdm
Copy link
Contributor

nostdm commented Oct 10, 2018

Solved, closing.

@nostdm nostdm closed this as completed Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request oracle Oracle related issue wallet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@draganm @asmckinlay @nostdm