Support reexporting from anywhere by wrapping in a declarative macro #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a downside we get slightly worse error messages as the filename and line number will point to the macro definition site instead of the call site.
|
Why is CI failing? It works on my machine, and we're running the same version of rustc... |
taiki-e
requested changes
Dec 27, 2020
There was a problem hiding this comment.
Thanks for the PR. I don't think this will work properly if EDIT: #46 (comment)async_stream (actual path of $crate) is not included in the direct dependency. I believe you need to use a trick like rust-lang/futures-rs#2124.
In any case, this PR needs a test to make sure reexporting works.
taiki-e
reviewed
Dec 27, 2020
|
The |
taiki-e
approved these changes
Dec 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
stream!andtry_stream!macros to be reexported from anywhere by having the procedural macro take a path toasync_stream, and having the macros inasync-streambe declarative macros that wrap the procedural ones and pass in$crate.