fix a handful of lints, one of which was breaking the build #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a compiler warning in recent Rust toolchains, which is breaking the CI `cargo check` run. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This fixes some miscellaneous Clippy lints, mostly in tests. These include: * Use of `clone()` on `SocketAddr`s (which implement `Copy`) * Unnecessary single-path-segment imports (which probably used to be `extern crate`s in earlier Rust?) * `'static` lifetimes in `const` type annotations (`const`s always have the `'static` lifetime) None of these were breaking the build on CI, but I figured I'd address them while I was fixing other lints.
LucioFranco
approved these changes
Jun 29, 2021
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 4, 2023
Closes #126. # 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream<S> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#65]: #74 [#65]: #93 [#65]: #125
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 4, 2023
Closes #126. # 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream<S> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#74]: #74 [#93]: #93 [#125]: #125
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 4, 2023
Closes #126. # 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream\<S\> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#74]: #74 [#93]: #93 [#125]: #125
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 4, 2023
# 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream\<S\> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#74]: #74 [#93]: #93 [#125]: #125
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 7, 2023
# 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream\<S\> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#74]: #74 [#93]: #93 [#125]: #125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes a number of lints. The most important one was the use
of a non-
format_args!expression in apanic!macro, which generatesa compiler warning in recent Rust toolchains, which is breaking the CI
cargo checkrun on PR #64.While I was here, I also fixed some miscellaneous Clippy lints, mostly
in tests. These include:
clone()onSocketAddrs (which implementCopy)extern crates in earlier Rust?)'staticlifetimes inconsttype annotations (consts always havethe
'staticlifetime)None of these were breaking the build on CI, but I figured I'd address
them while I was fixing other lints.