Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream<S> #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quininer
reviewed
Sep 30, 2021
quininer
requested changes
Oct 1, 2021
…nd tokio_rustls::TlsStream enum
|
Implemented the requested changes. |
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 4, 2023
Closes #126. # 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream<S> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#65]: #74 [#65]: #93 [#65]: #125
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 4, 2023
Closes #126. # 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream<S> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#74]: #74 [#93]: #93 [#125]: #125
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 4, 2023
Closes #126. # 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream\<S\> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#74]: #74 [#93]: #93 [#125]: #125
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 4, 2023
# 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream\<S\> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#74]: #74 [#93]: #93 [#125]: #125
Noah-Kennedy
added a commit
that referenced
this pull request
Feb 7, 2023
# 0.3.1 (February 4th, 2023) ### Additions - Add Vendored Feature ([#125]) - Implement AsRawFd for both tokio-rustls and tokio-native-tls TlsStream\<S\> ([#74]) ### Internal - Fix warning about renamed lint ([#93]) - fix a handful of lints, one of which was breaking the build ([#65]) [#65]: #65 [#74]: #74 [#93]: #93 [#125]: #125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been needing this to
getsockopton the underlying stream. I've been maintaining a fork like that for a long time now but never upstreamed it.Edit: I've removed the
AsyncRead + AsyncWrite + Unpintrait bounds onSfortokio-native-tls'sTlsStream<S>'sget_ref(&self)andget_mut(&self)functions. They didn't seem necessary and the compiler would've needed me to only be able to implementAsRawFdifSwas alsoAsyncRead + AsyncWrite + Unpinwhich didn't make sense to me. I'm happy to bring them back if that's a problem.