task: also instrument streams #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
reviewed
Nov 8, 2022
Cargo.toml
Outdated
| @@ -19,6 +19,7 @@ default = ["rt"] | |||
| rt = ["tokio"] | |||
|
|
|||
| [dependencies] | |||
| futures-core = "0.3.25" | |||
There was a problem hiding this comment.
Could prob depend on tokio-stream instead?
|
You will need to merge in master once #32 is merged to fix the CI failures. |
|
You can merge master now. |
Using pretty much the same logic as for futures, instrument streams as well.
duarten
force-pushed
the
duarte/instrument-stream
branch
from
17138c9
to
3e7ecac
Compare
|
Ping 😅 |
|
The doc tests also fail for me on main. |
|
That's annoying. I'm not sure what's causing it. |
|
Since the crate monitors tokio's internals, there's an inherent amount of flakiness. Perhaps we could use nextest with retries in CI instead. |
|
Is it just a flaky test? I saw it fail several times in a row. |
Darksonn
approved these changes
Dec 14, 2022
Merged
Noah-Kennedy
added a commit
that referenced
this pull request
Mar 6, 2023
# 0.2.0 (March 6th, 2023) ### Added - Add `Debug` implementations. ([#28]) - rt: add concrete `RuntimeIntervals` iterator type ([#26]) - rt: add budget_forced_yield_count metric ([#39]) - rt: add io_driver_ready_count metric ([#40]) - rt: add steal_operations metric ([#37]) - task: also instrument streams ([#31]) ### Documented - doc: fix count in `TaskMonitor` docstring ([#24]) - doc: the description of steal_count ([#35]) [#24]: #24 [#26]: #26 [#28]: #28 [#31]: #31 [#35]: #35 [#37]: #37 [#39]: #39 [#40]: #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pretty much the same logic as for futures, instrument streams as
well.
Fixes #30