Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concrete RuntimeMetricsIter type #26

Merged
merged 2 commits into from
May 23, 2022

Conversation

sd2k
Copy link
Contributor

@sd2k sd2k commented Mar 25, 2022

Using return-position-impl-trait for the iterator returned by RuntimeMonitor::intervals means that users can't name the type to store it without boxing the iterator. I'd like to be able to do that in a crate to add Prometheus integration ideally (although boxing isn't really the end of the world there).

@LucioFranco
Copy link
Member

I think we can add this, I think you may need to force push or something to get CI going again.

@LucioFranco LucioFranco requested review from carllerche and jswrenn and removed request for carllerche May 9, 2022 15:06
Using return-position-impl-trait for this iterator means that users
can't name the type to store it without boxing the iterator. I'd like to
be able to do that in a [crate to add Prometheus
integration][tokio-metrics-prometheus] ideally
(although boxing isn't really the end of the world there).

[tokio-metrics-prometheus]: https://github.com/sd2k/tokio-metrics-prometheus
@sd2k sd2k force-pushed the add-concrete-runtime-metrics-iter-type branch from 09a0aee to 3153e86 Compare May 9, 2022 15:18
src/runtime.rs Outdated Show resolved Hide resolved
@sd2k sd2k force-pushed the add-concrete-runtime-metrics-iter-type branch from af56f69 to 3633799 Compare May 19, 2022 19:59
@sd2k
Copy link
Contributor Author

sd2k commented May 19, 2022

Sorry, I got the intra-doc link wrong for the last CI run, should be fixed now.

@jswrenn jswrenn merged commit b88a22a into tokio-rs:main May 23, 2022
@jswrenn jswrenn added this to the next milestone May 23, 2022
@Noah-Kennedy Noah-Kennedy mentioned this pull request Mar 6, 2023
Noah-Kennedy added a commit that referenced this pull request Mar 6, 2023
# 0.2.0 (March 6th, 2023)

### Added
- Add `Debug` implementations. ([#28])
- rt: add concrete `RuntimeIntervals` iterator type ([#26])
- rt: add budget_forced_yield_count metric ([#39])
- rt: add io_driver_ready_count metric ([#40])
- rt: add steal_operations metric ([#37])
- task: also instrument streams ([#31])

### Documented
- doc: fix count in `TaskMonitor` docstring ([#24])
- doc: the description of steal_count ([#35])

[#24]: #24
[#26]: #26
[#28]: #28
[#31]: #31
[#35]: #35
[#37]: #37
[#39]: #39
[#40]: #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants