-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steal_operations metric #37
Conversation
Bumping the required tokio version is fine. |
3102187
to
277eca4
Compare
Expose the new `steal_operations` metric which tracks what was previously documented to be `steal_count`.
277eca4
to
410e7e1
Compare
@@ -31,7 +31,7 @@ futures = "0.3.21" | |||
num_cpus = "1.13.1" | |||
serde = { version = "1.0.136", features = ["derive"] } | |||
serde_json = "1.0.79" | |||
tokio = { version = "1.15.0", features = ["full", "rt", "time", "macros", "test-util"] } | |||
tokio = { version = "1.26.0", features = ["full", "rt", "time", "macros", "test-util"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this change is here. This was already set. I wonder if GitHub's viewer is bugged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was for the dev-dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah
# 0.2.0 (March 6th, 2023) ### Added - Add `Debug` implementations. ([#28]) - rt: add concrete `RuntimeIntervals` iterator type ([#26]) - rt: add budget_forced_yield_count metric ([#39]) - rt: add io_driver_ready_count metric ([#40]) - rt: add steal_operations metric ([#37]) - task: also instrument streams ([#31]) ### Documented - doc: fix count in `TaskMonitor` docstring ([#24]) - doc: the description of steal_count ([#35]) [#24]: #24 [#26]: #26 [#28]: #28 [#31]: #31 [#35]: #35 [#37]: #37 [#39]: #39 [#40]: #40
Follow-up to tokio-rs#35. The new metric is available starting with tokio v1.25.0.
Follow-up to #35.
The new metric is available starting with tokio v1.25.0.
Would it be okay to just bump the required tokio version and release a new tokio-metrics version? Or would you prefer something more advanced like version detection in a build script?
Edit: A different PR bumped the required tokio version already. Rebased.