-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare tokio-macros 1.1.0 #3505
Conversation
I think we need to release tokio-macros with path (dev-)dependency on tokio first. Otherwise, I think tokio's -Zminimal-versions support will be broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from concern on the order of release.
Are you sure? I don't think Tokio depends on this new option except for a few tests. |
I don't think the build of tokio itself will break, but I think running -Zminimal-versions check on a crate that depends on tokio 1.2 and uses that option should break (due to tokio 1.2 can depend on tokio-macros 1.0). |
Right, because then if they use the option on the macro, their tokio-macros is not recent enough. Can you elaborate on your solution to the issue? I guess we could just release this first, then release Tokio depending on this version. |
Oh, I hadn't even noticed that this is just a dev-dependency. |
Added
start_paused
option to macros (Make test-util paused time fully deterministic #3492)This PR is blocked on making a Tokio release. I will rerun CI once that has happened.