Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare tokio-macros 1.1.0 #3505

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Feb 5, 2021

Added

This PR is blocked on making a Tokio release. I will rerun CI once that has happened.

@Darksonn Darksonn added the A-tokio-macros Area: The tokio-macros crate label Feb 5, 2021
@taiki-e
Copy link
Member

taiki-e commented Feb 5, 2021

This PR is blocked on making a Tokio release.

I think we need to release tokio-macros with path (dev-)dependency on tokio first. Otherwise, I think tokio's -Zminimal-versions support will be broken.

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from concern on the order of release.

@Darksonn
Copy link
Contributor Author

Darksonn commented Feb 5, 2021

Are you sure? I don't think Tokio depends on this new option except for a few tests.

@taiki-e
Copy link
Member

taiki-e commented Feb 5, 2021

I don't think the build of tokio itself will break, but I think running -Zminimal-versions check on a crate that depends on tokio 1.2 and uses that option should break (due to tokio 1.2 can depend on tokio-macros 1.0).

@Darksonn
Copy link
Contributor Author

Darksonn commented Feb 5, 2021

Right, because then if they use the option on the macro, their tokio-macros is not recent enough. Can you elaborate on your solution to the issue?

I guess we could just release this first, then release Tokio depending on this version.

@Darksonn
Copy link
Contributor Author

Darksonn commented Feb 5, 2021

Oh, I hadn't even noticed that this is just a dev-dependency.

@Darksonn Darksonn merged commit d41882e into master Feb 5, 2021
@Darksonn Darksonn deleted the prepare-tokio-macros-1.1.0 branch February 5, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio-macros Area: The tokio-macros crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants