Skip to content

Commit

Permalink
subscriber: impl Subscribe for FilterFn and DynFilterFn (#1546)
Browse files Browse the repository at this point in the history
## Motivation

Currently, the `FilterFn` and `DynFilterFn` filters are only usable as
`Filter`s for per-subscriber filtering. However, there's no real reason
they can't _also_ have `Subscribe` implementations, making them usable
as global filters as well.

## Solution

This branch adds `Subscribe` implementations to `FilterFn` and
`DynFilterFn`, and moves them into their own file. It also changes the
feature flagging so that the "registry" feature is only required for the
`Filter` implementations --- the types themselves don't involve any
feature-flagged code, only the `Filter` trait.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
  • Loading branch information
hawkw committed Mar 24, 2022
1 parent 5f5f24c commit 6433c64
Show file tree
Hide file tree
Showing 3 changed files with 751 additions and 649 deletions.

0 comments on commit 6433c64

Please sign in to comment.