subscriber: impl Layer for FilterFn and DynFilterFn #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
davidbarsky
approved these changes
Sep 10, 2021
davidbarsky
pushed a commit
that referenced
this pull request
Nov 29, 2021
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-layer filtering. However, there's no real reason they can't _also_ have `Layer` implementations, making them usable as global filters as well. ## Solution This branch adds `Layer` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 23, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 23, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 24, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 24, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 24, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 24, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 24, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 24, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 24, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Mar 24, 2022
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-subscriber filtering. However, there's no real reason they can't _also_ have `Subscribe` implementations, making them usable as global filters as well. ## Solution This branch adds `Subscribe` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
## Motivation Currently, the `FilterFn` and `DynFilterFn` filters are only usable as `Filter`s for per-layer filtering. However, there's no real reason they can't _also_ have `Layer` implementations, making them usable as global filters as well. ## Solution This branch adds `Layer` implementations to `FilterFn` and `DynFilterFn`, and moves them into their own file. It also changes the feature flagging so that the "registry" feature is only required for the `Filter` implementations --- the types themselves don't involve any feature-flagged code, only the `Filter` trait. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
FilterFnandDynFilterFnfilters are only usable asFilters for per-layer filtering. However, there's no real reason theycan't also have
Layerimplementations, making them usable as globalfilters as well.
Solution
This branch adds
Layerimplementations toFilterFnandDynFilterFn, and moves them into their own file. It also changes thefeature flagging so that the "registry" feature is only required for the
Filterimplementations --- the types themselves don't involve anyfeature-flagged code, only the
Filtertrait.