core: impl Value for dyn Error + Send/Sync
#2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
requested changes
Apr 11, 2022
There was a problem hiding this comment.
Thanks, this looks good to me.
In general, it's a lot easier if we make changes that apply to both the master and v0.1.x branches on the master branch, and then backport them to v0.1.x when the change applies to both v0.1.x and v0.2. It's a bit more work to have to backport and forward-port changes. Would you mind changing this PR to be based on master, and I'll handle backporting it after it merges?
|
Ok. I wasn't sure how best to handle that. I'll rebase it onto |
lilyball
force-pushed
the
error-send-sync-value
branch
from
c9cfe7e
to
0446b59
Compare
|
Oh good, GitHub appears to be rather confused by me force-pushing and then changing the base >_< I'll try again. |
`Value` was already implemented for `dyn Error + 'static`, but rust doesn't silently coerce trait objects. This means that passing an error of type `dyn Error + Send + Sync + 'static` would not work. These extra impls just delegate to the existing `dyn Error + 'static` impl. Also update one of the examples to use `dyn Error + Send + Sync` to demonstrate that this works. Refs: tokio-rs#1308
lilyball
force-pushed
the
error-send-sync-value
branch
from
0446b59
to
f7776be
Compare
hawkw
approved these changes
Apr 11, 2022
hawkw
pushed a commit
that referenced
this pull request
Apr 12, 2022
## Motivation `Value` was already implemented for `dyn Error + 'static`, but rust doesn't silently coerce trait objects. This means that passing an error of type `dyn Error + Send + Sync + 'static` would not work. This is related to #1308. ## Solution Add impls for `dyn Error + …` variants for `Send`, `Sync`, and `Send + Sync`. These extra impls just delegate to the existing `dyn Error + 'static` impl. Also update one of the examples to use `dyn Error + Send + Sync` to demonstrate that this works. Refs: #1308
hawkw
added a commit
that referenced
this pull request
Apr 12, 2022
# 0.1.25 (April 12, 2022) This release adds additional `Value` implementations for `std::error::Error` trait objects with auto trait bounds (`Send` and `Sync`), as Rust will not auto-coerce trait objects. Additionally, it fixes a bug when setting scoped dispatchers that was introduced in the previous release ([v0.1.24]). ### Added - `Value` implementations for `dyn Error + Send + 'static`, `dyn Error + Send + Sync + 'static`, `dyn Error + Sync + 'static` ([#2066]) ### Fixed - Failure to use the global default dispatcher if a thread has set a scoped default prior to setting the global default, and unset the scoped default after setting the global default ([#2065]) Thanks to @lilyball for contributing to this release! [v0.1.24]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.24 [#2066]: #2066 [#2065]: #2065
hawkw
added a commit
that referenced
this pull request
Apr 12, 2022
# 0.1.25 (April 12, 2022) This release adds additional `Value` implementations for `std::error::Error` trait objects with auto trait bounds (`Send` and `Sync`), as Rust will not auto-coerce trait objects. Additionally, it fixes a bug when setting scoped dispatchers that was introduced in the previous release ([v0.1.24]). ### Added - `Value` implementations for `dyn Error + Send + 'static`, `dyn Error + Send + Sync + 'static`, `dyn Error + Sync + 'static` ([#2066]) ### Fixed - Failure to use the global default dispatcher if a thread has set a scoped default prior to setting the global default, and unset the scoped default after setting the global default ([#2065]) Thanks to @lilyball for contributing to this release! [v0.1.24]: https://github.com/tokio-rs/tracing/releases/tag/tracing-core-0.1.24 [#2066]: #2066 [#2065]: #2065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Valuewas already implemented fordyn Error + 'static, but rust doesn't silently coerce trait objects. This means that passing an error of typedyn Error + Send + Sync + 'staticwould not work. This is related to #1308.Solution
Add impls for
dyn Error + …variants forSend,Sync, andSend + Sync. These extra impls just delegate to the existingdyn Error + 'staticimpl.Also update one of the examples to use
dyn Error + Send + Syncto demonstrate that this works.