futures: replace pin_utils with pin_project
#374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove an unnecessary clone of the dispatcher or span from poll impls. Also, it is commonly used in other crates (e.g. `tokio`), so might make users' dependency graphs smaller. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added
crate/futures
LucioFranco
approved these changes
Oct 5, 2019
taiki-e
reviewed
Oct 6, 2019
| #[derive(Clone, Debug)] | ||
| pub struct WithDispatch<T> { | ||
| // cfg_attr doesn't work inside structs, apparently... |
There was a problem hiding this comment.
Oh, this is related to the order of application of proc-macro (taiki-e/pin-project#68 (comment)). I will fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove an unnecessary clone of the dispatcher or span
from poll impls. Also, it is commonly used in other crates (e.g.
tokio), so might make users' dependency graphs smaller.Signed-off-by: Eliza Weisman eliza@buoyant.io