Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(subsriber): rename Layer::new_span method to Layer::on_new_span for consistency #662

Closed
wants to merge 1 commit into from
Closed

refactor(subsriber): rename Layer::new_span method to Layer::on_new_span for consistency #662

wants to merge 1 commit into from

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Apr 3, 2020

Motivation

close #630

Solution

Deprecate the previous method.

@bnjjj
refactor(subsriber): rename Layer::new_span method to Layer::on_new_s…
6ee4c63 
…pan for consistency tokio-rs#630

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj mentioned this pull request Apr 3, 2020
Closed
@hawkw hawkw added crate/subscriber Related to the `tracing-subscriber` crate meta/breaking This is a breaking change, and should wait until the next breaking release. labels Apr 3, 2020
@hawkw hawkw added this to the tracing-subscriber 0.3 milestone Apr 3, 2020
@bnjjj bnjjj requested review from hawkw and a team as code owners August 5, 2020 03:08
@hawkw hawkw changed the base branch from master to subscriber-0.3-dev August 6, 2020 22:09
hawkw added a commit that referenced this pull request Oct 22, 2021
@hawkw
subscriber: rename Subscribe::new_span to on_new_span
303dbd0 
While we're breaking things, we may as well do this as well.

Closes #630
Closes #662
@hawkw hawkw mentioned this pull request Oct 22, 2021
Merged
@hawkw hawkw closed this in #1674 Oct 22, 2021
hawkw added a commit that referenced this pull request Oct 22, 2021
@hawkw
subscriber: rename Subscribe::new_span to on_new_span (#1674)
2b3aa06 
While we're breaking things, we may as well do this as well.

Closes #630
Closes #662
hawkw added a commit that referenced this pull request Oct 22, 2021
@hawkw
subscriber: rename Layer::new_span to on_new_span (#1674)
3566804 
While we're breaking things, we may as well do this as well.

Closes #630
Closes #662
hawkw added a commit that referenced this pull request Oct 22, 2021
@hawkw
subscriber: rename Layer::new_span to on_new_span (#1674)
3f05ed6 
While we're breaking things, we may as well do this as well.

Closes #630
Closes #662
hawkw added a commit that referenced this pull request Oct 22, 2021
@hawkw
subscriber: rename Layer::new_span to on_new_span (#1674)
8777d2c 
While we're breaking things, we may as well do this as well.

Closes #630
Closes #662
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
subscriber: rename Layer::new_span to on_new_span (tokio-rs#1674)
6386a7c 
While we're breaking things, we may as well do this as well.

Closes tokio-rs#630
Closes tokio-rs#662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw Awaiting requested review from hawkw hawkw is a code owner

Assignees
No one assigned
Labels
crate/subscriber Related to the `tracing-subscriber` crate meta/breaking This is a breaking change, and should wait until the next breaking release.
Projects
None yet
Milestone
tracing-subscriber 0.3
Development

Successfully merging this pull request may close these issues.

subscriber: Rename Layer::new_span method for consistency
2 participants
@bnjjj @hawkw