Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove json support from tracing-subscriber's default features #653

Closed
Ralith opened this issue Mar 31, 2020 · 4 comments · Fixed by #665
Closed

Remove json support from tracing-subscriber's default features #653

Ralith opened this issue Mar 31, 2020 · 4 comments · Fixed by #665
Labels
crate/subscriber Related to the `tracing-subscriber` crate kind/feature New feature or request meta/breaking This is a breaking change, and should wait until the next breaking release.
Milestone
tracing-subscribe...

Comments

@Ralith
Copy link
Collaborator

Ralith commented Mar 31, 2020

json is unnecessary for many purposes, and the dependencies it pulls in can substantially fatten the build of an application which does not otherwise require serde or json support. It'd be nice to be able to use tracing-subscriber without having to copy-paste default-features = false, features = ["env-filter", "fmt", "ansi", "chrono"] for pretty, comparatively lightweight terminal output around all the time.
@hawkw
Copy link
Member

hawkw commented Mar 31, 2020

Yeah, the JSON feature should probably not be on by default. We can change this, but it'll have to wait for tracing-subscriber 0.3.

I think in general, we may want to prune the tracing-subscriber crate's default features a bit in 0.3, since opting out of features is significantly more fraught than opting into them.

@hawkw hawkw added crate/subscriber Related to the `tracing-subscriber` crate kind/feature New feature or request meta/breaking This is a breaking change, and should wait until the next breaking release. labels Mar 31, 2020
@hawkw hawkw added this to the tracing-subscriber 0.3 milestone Mar 31, 2020
@bnjjj
Copy link
Contributor

bnjjj commented Apr 3, 2020

As I already introduce breaking changes in my PR #662 I can add this one also inside if you want ?

@hawkw
Copy link
Member

hawkw commented Apr 3, 2020

@bnjjj A PR to make this change would be great, and would definitely help us move towards getting 0.3 ready to release. Let's do it in a separate pull request from #662, though. Since we merge pull requests by squashing them into a single commit, it's best for each one to contain one logical change.

bnjjj added a commit to bnjjj/tracing that referenced this issue Apr 4, 2020
@bnjjj
Remove json support from tracing-subscriber's default features tokio-…
a020752 
…rs#653

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj mentioned this issue Apr 4, 2020
Merged
hawkw pushed a commit that referenced this issue Nov 21, 2020
@bnjjj
subscriber: remove json from default features #653 (#665)
5535b2b 
## Motivation

Closes #653 


Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@hawkw
Copy link
Member

hawkw commented Oct 21, 2021

Done in #1647

@hawkw hawkw closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crate/subscriber Related to the `tracing-subscriber` crate kind/feature New feature or request meta/breaking This is a breaking change, and should wait until the next breaking release.
Projects
None yet
Milestone
tracing-subscriber 0.3
Development

Successfully merging a pull request may close this issue.

Remove json support from tracing-subscriber's default features #653 bnjjj/tracing
3 participants
@Ralith @hawkw @bnjjj