fix: i18next update with addResourceBundle #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the PR, could you check the tests and eslint? I vaguely remember that this was not so simple and the test suggests that it's somehow not being overriten. The pipelines in PRs from forks don't work fully, but you should be able to run jest tests locally. |
|
Hi! Sure, some of the tests failed due to the static translations (since I removed the resource check by mistake), by keeping the check everything seems to work like a charm |
|
Ok, cool everything is working. Thanks for the PR ❤️ |
stepan662
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to solve some translations missing in i18next-tolgee adapter. More details in the following issue: #3305