Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: email resend sign up view fix #2421

Merged
merged 18 commits into from
Aug 2, 2024
Merged

fix: email resend sign up view fix #2421

merged 18 commits into from
Aug 2, 2024

Conversation

huglx
Copy link
Collaborator

@huglx huglx commented Jul 24, 2024

remove email verification alert when signing up
add a counter until the next email verification request

JanCizmar
JanCizmar reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@JanCizmar JanCizmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I would mich rather make the button disabled for one minute and put there a countdown (into the disabled button), so the user cannot even hit the rate limit, when using the system normally.

Like here:
image

@JanCizmar JanCizmar self-requested a review July 29, 2024 08:06
JanCizmar
JanCizmar requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@JanCizmar JanCizmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why for the god sake are you letting me to hit the button 3 times before it starts the countdown? The countdown should be there immediately after signed up / hit the button, so it's not tempting to hit the button when it's useless.

backend/app/src/main/kotlin/io/tolgee/ExceptionHandlers.kt Outdated Show resolved Hide resolved
backend/data/src/main/kotlin/io/tolgee/security/ratelimit/RateLimitResponseBody.kt Outdated Show resolved Hide resolved
backend/data/src/main/kotlin/io/tolgee/security/ratelimit/RateLimitService.kt Show resolved Hide resolved
webapp/src/fixtures/useTimerCountdown.ts Outdated Show resolved Hide resolved
@huglx
fix: increase timer delay after click, and start timer if it's rate l…
4bf7877 
…imit error(in case the user has somehow hit the limit)
@JanCizmar JanCizmar merged commit c1d79f8 into main Aug 2, 2024
29 checks passed
@JanCizmar JanCizmar deleted the ivanmanzhosov/email-resend-sign-up-view-fix branch August 2, 2024 07:06
TolgeeMachine pushed a commit that referenced this pull request Aug 2, 2024
@semantic-release-bot
chore(release): 3.70.7 [skip ci]
350019d 
## [3.70.7](v3.70.6...v3.70.7) (2024-08-02)

### Bug Fixes

* email resend sign up view fix ([#2421](#2421)) ([c1d79f8](c1d79f8))
@JanCizmar JanCizmar linked an issue Aug 13, 2024 that may be closed by this pull request
Ability to resend registration email #968
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepan662 stepan662 stepan662 left review comments

@JanCizmar JanCizmar JanCizmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to resend registration email
3 participants
@huglx @stepan662 @JanCizmar