Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oxide to v1.3-beta #17

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Update oxide to v1.3-beta #17

merged 2 commits into from
Sep 8, 2020

Conversation

Eeems
Copy link
Member

@Eeems Eeems commented Sep 8, 2020

No description provided.

@@ -1,6 +1,6 @@
# vim: set ft=sh:
pkgname=oxide
pkgver=0.0.0-4
pkgver=0.0.0-5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that when upstream has a versioning scheme (as it is seems to be the case with oxide), it makes sense to use it in the package version. We just need to be careful with the beta component of your version number, since we need to make sure that if a non-beta v1.3 comes out, it is recognized as a newer version. For example, using 1.3-beta-1 would be bad because it would be sorted as a more recent version than 1.3-1 according to the Debian version comparison rules. We can leverage the special ~ symbol which is always sorted lower than any other character by those same rules.

TL;DR: I’d suggest using pkgver=1.3~beta-1 as the package version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I decided not to touch it since I wasn't sure what version numbering is allowed in the ipkg format.

@matteodelabre
Copy link
Member

Excellent, thanks!

@matteodelabre matteodelabre merged commit fc9170a into toltec-dev:testing Sep 8, 2020
@Eeems Eeems deleted the patch-1 branch September 11, 2020 05:39
@matteodelabre matteodelabre added the packages Add or improve packages of the repository label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants